Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove old stamping #2312

Merged
merged 1 commit into from
Nov 25, 2020
Merged

chore: remove old stamping #2312

merged 1 commit into from
Nov 25, 2020

Conversation

alexeagle
Copy link
Collaborator

BREAKING CHANGE:

  • rollup_bundle config_file no longer has substitutions from a "bazel_stamp_file" - use bazel_version_file instead
  • pkg_npm no longer has replace_with_version attribute, use substitutions instead

Fixes #2158

@google-cla google-cla bot added the cla: yes label Nov 25, 2020
chore: remove old stamping
ff65999 
BREAKING CHANGE:
- rollup_bundle config_file no longer has substitutions from a "bazel_stamp_file" - use bazel_version_file instead
- pkg_npm no longer has replace_with_version attribute, use substitutions instead

Fixes bazel-contrib#2158
gregmagolan
gregmagolan approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit 68b18d8 into bazel-contrib:3.x Nov 25, 2020
@alexeagle alexeagle mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@jbedard jbedard Awaiting requested review from jbedard jbedard is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair soldair is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @gregmagolan